Skip to content

use equal explicit class to replace anonymous class#4027

Merged
ralf0131 merged 1 commit intoapache:masterfrom
tswstarplanet:available_cluster
May 12, 2019
Merged

use equal explicit class to replace anonymous class#4027
ralf0131 merged 1 commit intoapache:masterfrom
tswstarplanet:available_cluster

Conversation

@tswstarplanet
Copy link
Copy Markdown
Contributor

@tswstarplanet tswstarplanet commented May 10, 2019

What is the purpose of the change

The anonymous class used in AvailableCluster's constructor has a equal explicit class, we can use the explicit one to replace the anonymous one.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 11, 2019

Codecov Report

Merging #4027 into master will increase coverage by 1.3%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #4027     +/-   ##
===========================================
+ Coverage     63.42%   64.73%   +1.3%     
- Complexity      564      600     +36     
===========================================
  Files           755      755             
  Lines         32425    34661   +2236     
  Branches       5145     5968    +823     
===========================================
+ Hits          20567    22438   +1871     
- Misses         9496     9830    +334     
- Partials       2362     2393     +31
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/rpc/cluster/support/AvailableCluster.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
...mmon/threadpool/support/AbortPolicyWithReport.java 83.33% <0%> (-5.56%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...c/protocol/dubbo/ReferenceCountExchangeClient.java 66.66% <0%> (-1.86%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.46% <0%> (-1.37%) 0% <0%> (ø)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 47.22% <0%> (-0.7%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/common/Constants.java 90.9% <0%> (ø) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...n/java/org/apache/dubbo/config/ProviderConfig.java 98.02% <0%> (+0.17%) 0% <0%> (ø) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1dd65...0f25880. Read the comment docs.

ralf0131
ralf0131 approved these changes May 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 added this to the 2.7.2 milestone May 12, 2019
@ralf0131 ralf0131 merged commit 6a3f4c7 into apache:master May 12, 2019
@caojiele caojiele mentioned this pull request May 12, 2019
Merged
6 tasks
@dubbo-bot dubbo-bot mentioned this pull request May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralf0131 ralf0131 ralf0131 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7.2

Development

Successfully merging this pull request may close these issues.

3 participants

@tswstarplanet @codecov-io @ralf0131
⚡